API review

Proposer: Kevin

Present at review:

• Tully
• Wim

Question / concerns / comments

Enter your thoughts on the API and any questions / concerns you have here. Please sign your name. Anything you want to address in the API review should be marked down here before the start of the meeting.

Tully

• All units should be REP 103 compliant http://www.ros.org/reps/rep-0103.html

• Units are not defined.

Kevin

At Wim and Tully's suggestion, I will call out the units to be in Celcius for temperature and rad/s for fan speed.

• (Tully) Can you update the propossal below?

Wim

• Units for rotational velocity are rad/sec (not Hz)
• Why are fan_speed, gpu_usage and memory_usage ints and not floats?
  • (Tully) I agree floats seems to be better

Meeting agenda

I would like to review the addition of a pr2_msgs/GPUStatus message for Diamondback. This message is for internal use only and designed to monitor the GPU status.

Text of message:

Header header
string product_name
string pci_device_id
string pci_location
string display
string driver_version
float32 temperature # Temperature in Celcius
float32 fan_speed # Fan speed in rad/s
float32 gpu_usage # Usage in percent
float32 memory_usage # Usage in percent

This is for machine-readable debugging of an NVIDIA Quadro 600 GPU that we've installed on our PR2's.

Conclusion

Message released in pr2_common 1.3.1.

Package status change mark change manifest)

• Action items that need to be taken.

• Major issues that need to be resolved